Add maximum repo string and title length validation - #1137
Open
Silver36-ship-it wants to merge 2 commits into
Open
Add maximum repo string and title length validation#1137Silver36-ship-it wants to merge 2 commits into
Silver36-ship-it wants to merge 2 commits into
Conversation
|
@Silver36-ship-it is attempting to deploy a commit to the ritik4ever's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Silver36-ship-it Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #759
Description
Type of change
Security Checklist
Please review the SECURITY_CHECKLIST.md and check off any items that apply. Reviewers must sign off on these items before merge.
Title: Add maximum repo/title length tests for
create_bountySummary:
Adds unit tests that validate repo and title length handling in the contracts package. Tests cover at-limit acceptance, over-limit rejection (returns
StringTooLong), and empty-string acceptance.Branch: AddMaximumRepoStringAndTitleLengthValidation
Files Changed:
What I changed:
create_bounty:MAX_REPO_LEN/MAX_TITLE_LENare accepted.MAX_REPO_LENfails withStringTooLong.Rationale:
Protects on-chain storage from unbounded growth by ensuring length limits are enforced and prevents regressions by asserting expected contract behavior.
Testing:
cargo test -p contractscargo test -p contracts test_create_bounty_repo_title_at_limit_succeedscargo test -p contracts test_create_bounty_repo_over_limit_failscargo test -p contracts test_create_bounty_empty_repo_title_succeedsExpected Results:
create_bountyenforcesMAX_REPO_LEN/MAX_TITLE_LENand returnsStringTooLongon over-limit inputs.Notes / Caveats:
StringTooLongerror (the test uses#[should_panic(expected = "StringTooLong")]).Checklist for PR:
cargo test -p contractsruns in CI.Suggested PR description (copy-paste):
Adds unit tests to validate repo/title string length handling in the Soroban contract.
StringTooLong)This prevents regressions around string-length validation that protects on-chain storage. Tests live in test.rs on branch AddMaximumRepoStringAndTitleLengthValidation. Run
cargo test -p contractsto verify.